Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add farcaster to social links #2724

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add farcaster to social links #2724

merged 2 commits into from
Dec 18, 2024

Conversation

dionysuzx
Copy link
Contributor

@dionysuzx dionysuzx commented Dec 18, 2024 •
edited
Loading

Description

This PR should allow 'farcaster' to be used as an option in the social icons schema. This is so that starlight users can add a social link to their farcaster site (eg. warpcast) like so:

social: {
    ...
    farcaster: 'https://warpcast.com/@someone`
}

Do I need to add a changeset..?

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1c235ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 18, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 1c235ea
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6762a26cb537c100086e55da
😎 Deploy Preview https://deploy-preview-2724--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@dionysuzx dionysuzx force-pushed the add-farcaster-social branch from 287c1d8 to bcafa58 Compare December 18, 2024 01:13
delucis
delucis approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dionysuzx! I believe this was the intention when someone first added the icon, but I guess we forgot to add the social schema part.

We’ll need a changeset so this is reflected in our changelog, but I can add one now before merging.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 18, 2024
@delucis delucis merged commit 02d7ac6 into withastro:main Dec 18, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dionysuzx @astrobot-houston @delucis